Skip to content

PR that raises vulnerabilities #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
christophe-havard-sonarsource wants to merge 3 commits into
base: master
Choose a base branch
from
Open

PR that raises vulnerabilities #2

christophe-havard-sonarsource wants to merge 3 commits into from

Conversation

@christophe-havard-sonarsource
Copy link

@christophe-havard-sonarsource christophe-havard-sonarsource commented Feb 22, 2022

No description provided.

@christophe-havard-sonarsource christophe-havard-sonarsource changed the title Create sqlquery.php PR that raises vulnerabilities Feb 22, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 31, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability E 1 Vulnerability
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ghost
Copy link

ghost commented Jun 28, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability E 2 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 28, 2022
View reviewed changes
sqlquery.php
{
$userId = $request->get('name');
$sql = "SELECT username FROM user WHERE id='$userId'";
$statement = $this->connection->prepare($sql);

Check failure

Code scanning / SonarCloudsquad-1

Database queries should not be vulnerable to injection attacks

<!--SONAR_ISSUE_KEY:AYGqXA5_KW4f87dK4H5--->Change this code to not construct SQL queries directly from user-controlled data.
sqlquery.php
{
$userId = $request->get('id');
$sql = "SELECT email FROM user WHERE id='$userId'";
$statement = $this->connection->prepare($sql);

Check failure

Code scanning / SonarCloudsquad-1

Database queries should not be vulnerable to injection attacks

<!--SONAR_ISSUE_KEY:AYGqXA5_KW4f87dK4H5_-->Change this code to not construct SQL queries directly from user-controlled data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@christophe-havard-sonarsource